[PATCH] Fix mpc7448hpc2 tsi108 device_type bug

Segher Boessenkool segher at kernel.crashing.org
Thu Jul 12 03:51:05 EST 2007


>>> Fix mpc7448hpc2 tsi108 device_type bug.
>>> Wrong device type will break the board startup.
>>
>>> -             device_type = "tsi108-bridge";
>>> +             device_type = "tsi-bridge";
>>
>> The OS code shouldn't use "device_type" at all for this,
>> but "compatible" instead.  You might want to fix that.
> I can understand you. Should we separate it into two steps:
> (1) Fix the bug in old style to ensure the  board work. I can see  
> other
> code in kernel tree will be affected by removing "device_type".
> (2) Using compatible instead of device_type for all associated boards
> and code.

Yes, good plan.

>> This patch is fine until you do of course.
> That is fine.

This is your step (1) :-)


Segher




More information about the Linuxppc-dev mailing list