[RFC][PATCH 6/8] Walnut DTS

Segher Boessenkool segher at kernel.crashing.org
Thu Jul 12 03:49:59 EST 2007


> +	UIC0: interrupt-controller0 {

Why not just "interrupt-controller"?

> +		#address-cells = <0>;
> +		#size-cells = <0>;

No need for these.
>
> +	plb {
> +		ranges;

Please make the valid address ranges explicit here.

> +		SDRAM0: memory-controller {
> +			compatible = "ibm,sdram-405gp", "ibm,sdram-440gp";

It's a bit weird to mention 440 here, since 405 is older.
Not a real problem, but if you still can change all relevant
OS code and device trees, I'd swap it around (make 440 trees
include the 405 "compatible" value).  Can you still do that
or is there a too big installed base already?

> +		POB0: opb {
> +			ranges;

Similar question as for PLB here.

> +			UART0: serial at ef600300 {
> +				current-speed = <2580>;

Write this in decimal?

Quite a nice tree btw :-)


Segher




More information about the Linuxppc-dev mailing list