[patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

Segher Boessenkool segher at kernel.crashing.org
Wed Jul 11 20:57:05 EST 2007


>>> +			compatible = "fsl,mpc86xx-pciex","86xx";
>>
>> And "xx" again.  Aren't the 85- and 86- PCIe controllers
>> compatible, btw?
>
> They are, but we need to distinguish between 83xx, 85xx, and 86xx  
> pci, pciex, pci-x controllers.

Sure, but if 85xx-pcie and 86xx-pcie are compatible, the OS
driver can match on the same "compatible" entry for both.
Just choose one -- "fsl,8641-pcie" or something.  It is a
good idea to put the exact name of the controller on the
board in the first "compatible" entry in case it is found
later that some specific model needs a workaround or some
other special treatment, but in general, everything can
just use the generic "grandfather" model to match on.


Segher




More information about the Linuxppc-dev mailing list