[PATCH 2/4] Add dma sector to mpc8641hpcn board dts

[Zhang Wei-r63237]

Hi, Segher, 

> -----Original Message-----
> From: Segher Boessenkool [mailto:segher at kernel.crashing.org] 
> 
> > +		dma at 21000{
> > +			compatible = "fsl,mpc8xxx-dma";
> 
> Please use a real name, not this "xxx" stuff.

Does the "xxx" seems to be an evil name? :-)

> 
> > +			reg = <21000 100>;
> > +			ranges = <0 21000 1000>;
> 
> These overlap, that can't be right; it is just begging for
> trouble.

There is no overlap. The 'reg' is used for the register of DMA
controller. And the ranges is used for belows channel registers.

Such as ch0 at 100, reg=<100 80>, in fact, the ch0 register address is
0x21100.

> 
> > +			ch0 at 100{
> > +				reg = <100 80>;
> > +				extended;
> 
> I think you want a little more detailed property name
> than "extended" here?

I've explained it in [PATCH 1/4] Add DMA sector to
Documentation/powerpc/booting-without-of.txt file.
As below:
+    - extended : Set the DMA channel to work at extended chain mode.
+                 If not set, the DMA channel will work at basic
+                 chain mode.

Thanks!
Wei.