[patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node

[Segher Boessenkool]

>  		pci1: pci at 8000 {
>  			interrupt-map-mask = <1f800 0 0 7>;

Set the mask to <1800 0 0 7>, and you need only 16
entries to encode the swizzle.  Except...

> +				/* bus 1 , idsel 0x2 Tsi310 bridge secondary */

...interrupts on bus 1 should be swizzled on bus 1, not
at the PHB.  Really.  It is a horrible workaround for a
non-existing problem to do it here, and I promise you
it _will_ come back to hurt you later.  Not a threat,
just a promise :-)

> -			compatible = "85xx";
> +			compatible = "fsl,mpc85xx-pci","85xx";

No more "xx" please...

> +		pci at a000 {
> +			interrupt-map-mask = <f800 0 0 7>;
> +			interrupt-map = <
> +
> +				/* IDSEL 0x0 (PEX) */
> +				00000 0 0 1 &mpic 0 1
> +				00000 0 0 2 &mpic 1 0
> +				00000 0 0 3 &mpic 2 0
> +				00000 0 0 4 &mpic 3 0>;

Why sense 0 for all but the first entry in this map?

> +			compatible = "fsl,mpc86xx-pciex","86xx";

And "xx" again.  Aren't the 85- and 86- PCIe controllers
compatible, btw?


Segher