[PATCH v2][POWERPC] document ipic level/sense info

Segher Boessenkool segher at kernel.crashing.org
Wed Jul 11 05:34:01 EST 2007


>>>> +Sense and level information follows the Linux convention
>>>> +(specified in include/linux/interrupt.h) and should be encoded
>>>> +as follows:
>>>> +
>>>> +       2 =  high to low edge sensitive type enabled
>>>> +       8 =  active low level sensitive type enabled
>>
>>> ... but it is probably worthwhile commentting that sense types 1 & 4
>>> are not supported; just to fill in the obvious gaps.  :-)
>>
>> Same for sense types 0, 3, 5, 6, ...
>>
>> Just name the sense types 0 and 1, similar to what all other
>> OF interrupt controller bindings do.
>
> Actually, all I am trying to do with this patch is document the
> current state of things.  The 2/8 sense type usage has been that
> way for a long time, and I'll defer to the 83xx maintainers
> if they see any value in changing it.
>
> Right now there are many DTS files with level/sense set to values
> like 8 and no indication anywhere where those values came from.

Ah right, too bad then.  Just document that only 2 and 8 make
sense on current hardware, in that case.


Segher




More information about the Linuxppc-dev mailing list