[PATCH] pseries: don't die if unknown/missing interrupt controller property

Sonny Rao sonny at burdell.org
Fri Jul 6 19:16:34 EST 2007


On Thu, Jul 05, 2007 at 08:37:34AM -0500, Olof Johansson wrote:
> On Sun, Jul 01, 2007 at 08:49:37PM -0400, Sonny Rao wrote:
> > The pseries platform does not have a default function for init_IRQ and
> > does not install one if it doesn't find or doesn't recognize an
> > interrupt controller in the device tree.  Currently, the kernel dies
> > when it tries to call the NULL init_IRQ() function.  Clean that up.
> 
> Doesn't it make more sense to make init_IRQ() check that the pointer is
> set instead? That'll work for more platforms than just pseries.

Yeah, that might be the simplest way.  The only reason I can think of
to do it this way is that (I think) every single other platform in
arch/powerpc statically initializes init_IRQ, with pseries being the
oddball.  It doesn't matter much to me, so I can post another patch in a
bit.

Sonny



More information about the Linuxppc-dev mailing list