[PATCH 5/9] ps3: Preallocate bootmem memory for ps3fb

[Geert Uytterhoeven]

On Tue, 30 Jan 2007, Michael Ellerman wrote:
> On Thu, 2007-01-25 at 18:50 +0100, Geert Uytterhoeven wrote:
> > Preallocate bootmem memory for the PS3 frame buffer device, which needs a
> > large block of physically-contiguous memory. The size of this memory block is
> > configurable:
> >   - The config option CONFIG_FB_PS3_DEFAULT_SIZE_M allows to specify the
> >     default amount of memory (in MiB) allocated to the virtual frame buffer.
> >   - The early boot parameter `ps3fb=xxx' allows to override the default value.
> >     It will be rounded up to a multiple of 1 MiB, if needed.
> > 
> > Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven at sonycom.com>
> > Signed-off-by: Geoff Levand <geoffrey.levand at am.sony.com>
> 
> Rather than doing the alloc in setup.c, defining a structure to the hold
> the params, and then exporting the structure - why don't you just do the
> alloc in the ps3 fb driver code, and have it all private in there?

Because at that time it's no longer possible to allocate such a big block of
memory.

We have a similar problem with the storage driver, which needs a block of 256
KiB of contiguous memory.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven at sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium