[PATCH 1/6] msi: Kill msi_lookup_irq
Paul Mackerras
paulus at samba.org
Mon Jan 29 09:01:11 EST 2007
Eric W. Biederman writes:
> @@ -693,15 +664,14 @@ int pci_enable_msi(struct pci_dev* dev)
> if (!pos)
> return -EINVAL;
>
> - WARN_ON(!msi_lookup_irq(dev, PCI_CAP_ID_MSI));
> + WARN_ON(!!dev->msi_enabled);
Minor nit: what's wrong with just WARN_ON(dev->msi_enabled) ?
Also here:
> @@ -836,16 +811,14 @@ int pci_enable_msix(struct pci_dev* dev, struct msix_entry *entries, int nvec)
> return -EINVAL; /* duplicate entry */
> }
> }
> - temp = dev->irq;
> - WARN_ON(!msi_lookup_irq(dev, PCI_CAP_ID_MSIX));
> + WARN_ON(!!dev->msix_enabled);
Paul.
More information about the Linuxppc-dev
mailing list