[PATCH 6/14] ps3: smp interrupt fixes

[Arnd Bergmann]

On Friday 26 January 2007 03:47, Geoff Levand wrote:
> Sorry, I don't quite understand what you mean by 'using a constant definition
> for it'.  Could you elaborate?

I assumed that '64' had a special meaning in this, which would be ideally
expressed by something like

#define PS3_BITMAP_MINALIGN 64

which it only has indirectly, instead

> As you suggested I have already changed this to:
> 
> struct ps3_bmp {
>         struct {
>                 u64 status;
>                 u64 unused_1[3];
>                 u64 mask;
>                 u64 unused_2[3];
>         };
>         u64 ipi_debug_brk_mask;
>         spinlock_t lock;
> };
> 
> struct ps3_private {
>         struct ps3_bmp bmp __attribute__ ((aligned (64)));
>         u64 node;
>         unsigned int cpu;
> };

it would be even better to add a comment to this struct like

/* aligned(64) because ps3_bmp must not cross page boundaries */

	Arnd <><