[PATCH 01/18] Include autoconf.h from the bootwrapper.

Paul Mackerras paulus at samba.org
Fri Jan 26 09:15:10 EST 2007


Scott Wood writes:

> So basically, there'd be several lines in the arch/powerpc/boot/Makefile
> like this?
> 
> cflags-$(CONFIG_6xx) += -DCONFIG_6xx
> cflags-$(CONFIG_8xx) += -DCONFIG_8xx
> cflags-$(CONFIG_E500) += -DCONFIG_E500
> BOOTCFLAGS += $(cflags-y)

No no no.  I said the Makefile could pass different flags to wrapper
depending on the config, that is, to the *invocation* of wrapper, not
the building of wrapper.  As it does already - if you have
CONFIG_PPC_PMAC, it runs wrapper with "-p pmac"; if you have
CONFIG_PPC_PSERIES, it runs wrapper with "-p pseries".  In your case
you would be using "-p myboard_uboot_bd_t_variant_59" or something
(hopefully more concise than that, of course :).

> I don't really see the point (a simple grep will show you all the config
> dependencies in the bootwrapper, to verify that it's only platform stuff
> and not actual options), but I can do it that way if you really want. 
> One way or another, the information has to be there, and it has to be
> compile-time or else the bd_info struct layout will be wrong.

So you will end up with a bunch of .o files, one for each possible
bd_t variant.  They will all get built and the appropriate one will
get selected by wrapper based on the value you give with the -p
option.  The line in arch/powerpc/boot/Makefile that defines src-plat
will list all of them.

Paul.



More information about the Linuxppc-dev mailing list