[PATCH 6/14] ps3: smp interrupt fixes

[Arnd Bergmann]

On Thursday 25 January 2007 03:40, Geoff Levand wrote:
> --- ps3-linux-dev.orig/arch/powerpc/platforms/ps3/interrupt.c
> +++ ps3-linux-dev/arch/powerpc/platforms/ps3/interrupt.c
> @@ -317,22 +317,23 @@ struct ps3_bmp {
>                 unsigned long unused_1[3];
>                 unsigned long mask;
>                 unsigned long unused_2[3];
> -       } __attribute__ ((packed));
> +       } __attribute__ ((aligned (64)));

Is that meant to be a 64 _byte_ alignment? By default, it is
already aligned to 64 bit.
If 64 byte is some magic requirement by the hypervisor, you
might want to make that explicit by using a constant definition
for it.

> --- ps3-linux-dev.orig/arch/powerpc/platforms/ps3/setup.c
> +++ ps3-linux-dev/arch/powerpc/platforms/ps3/setup.c
> @@ -109,6 +109,7 @@ static int __init ps3_probe(void)
>                 return 0;
>  
>         powerpc_firmware_features |= FW_FEATURE_PS3_POSSIBLE;
> +       cur_cpu_spec->cpu_features |= CPU_FTR_SMT;
>  
>         ps3_os_area_init();
>         ps3_mm_init();
> 
CPU_FTRS_CELL already contains CPU_FTR_SMT, why do you need to enable
it explicitly?

	Arnd <><