[patch 1/1] updated version, fixed the compiler warning

[Segher Boessenkool]

>>>> +static int __devexit ipmi_of_remove(struct of_device *dev)
>>>> +{
>>>> +	/* should call
>>>> +	 * cleanup_one_si(dev->dev.driver_data); */
>>>> +	return 0;
>>>> +}
>>>
>>> If your remove doesn't work, don't implement one.
>>
>> As explained before, it's the underlying thing that doesn't
>> work.  Yeah someone should fix it one day.  Still it's better
>> to have this comment than to not have anything at all.  An
>> XXX FIXME: tag wouldn't be out of place of course.
>
> If the underlying ipmi stuff cannot cleanup, then the driver should  
> not
> have a module_exit() so the module cannot be removed.

Well the "base" IPMI code has this same FIXME.  Also, it seems
to be safe to just exit in this particular case )not a clean
way to go about things, of course).

Anyway, it sounds like Christian has a fix, let's see what he
comes up with :-)


Segher