[PATCH 2/2] move pSeries nvram code to neutral location

Segher Boessenkool segher at kernel.crashing.org
Thu Jan 25 11:57:27 EST 2007


> Move arch/powerpc/platforms/pseries/nvram.c to
> arch/powerpc/sysdev/rtas_nvram.c so other platforms with RTAS support
> for manipulating nvram can use it.
>
> Add a RTAS_NVRAM Kconfig option which triggers the build of
> arch/powerpc/sysdev/rtas_nvram.o.
>
> Select RTAS_NVRAM for pSeries and Maple platforms.

The patch seems to select it for pSeries and iSeries, instead?

> Signed-off-by: Nathan Lynch <ntl at pobox.com>

> +config RTAS_NVRAM
> +	bool
> +	default n

No need for "default n", all defaults are "n" by default ;-)

> --- a/arch/powerpc/platforms/pseries/nvram.c
> +++ /dev/null

> --- /dev/null
> +++ b/arch/powerpc/sysdev/rtas_nvram.c

You can do a "git diff -M" -- that way, we can see that you're
not trying to sneak in any changes ;-) (and it makes you patch
much more legible and smaller, too).


Looks good otherwise, thanks!


Segher




More information about the Linuxppc-dev mailing list