[PATCH 14/18] Make flatdevtree_misc's cxt global.

Mark A. Greer mgreer at mvista.com
Thu Jan 25 10:16:14 EST 2007


On Wed, Jan 24, 2007 at 03:07:26PM -0600, Scott Wood wrote:
> This allows platform code to use flatdevtree functions directly.
> 
> Signed-off-by: Scott Wood <scottwood at freescale.com>
> ---

Scott,

I have to to thru your patches in detail but I have a comment about this
patch...

I don't think this one is a good idea.  Platform code shouldn't be using
flatdevtree.c code directly because it will be replaced by libfdt code.
For functionality that isn't already accessible, you should define an
interface then access it thru the interface glue code (i.e.,
flatdevtree_misc.c).  This will separate the calls that bootwrapper code
uses from whatever the underlying implementation is.

Mark



More information about the Linuxppc-dev mailing list