[PATCH 3/5] [FS_ENET] OF-related fixup for FEC and SCC MAC's

Paul Mackerras paulus at samba.org
Mon Jan 22 21:07:01 EST 2007


Vitaly Bordug writes:

> +#ifndef CONFIG_PPC_MERGE
>  	FW(fecp, ivec, (fep->interrupt / 2) << 29);
> -	
> +#else
> +	FW(fecp, ivec, (irq_map[fep->interrupt].hwirq / 2) << 29);
> +#endif

This would be much cleaner if you use virq_to_hw() and add a
definition of virq_to_hw to the asm-ppc headers, so that you can avoid
putting ifdefs in code.

Also, it seems a bit bogus to be using the hardware interrupt number
directly here.

Is it just 82xx that uses this driver, or do other chips (85xx?) use
it too?

Paul.



More information about the Linuxppc-dev mailing list