[PATCH 16/19] powerpc: udbg supports for Celleb

[Ishizaki Kou]

Ben-san,

Thank you for your comment.

> > +void __init udbg_init_debug_beat(void)
> > +{
> > +	celleb_vtermno = 0;
> > +	udbg_putc = udbg_putc_beat;
> > +	udbg_getc = udbg_getc_beat;
> > +	udbg_getc_poll = udbg_getc_poll_beat;
> > +}

> Is celleb_vtermno ever != 0 ? I don't see that happening in your
> patch...

No. celleb_vtermno is currently fixed to 0. I had a plan to change
it at runtime, but I forgot to implement such behavior.

> If not, I would just remove it and just pass 0 directly :-) Or make it a
> constant instead of a variable. Note that early debug is really just
> that: optional early debugging which, when enabled, is likely to prevent
> booting on any other platform, so only for use with debug builds. If you
> ever need another value in here, thus, it's perfectly fine to make it a
> Kconfig option that can be set at build time.

Or finding vterm number on the commandline (like pSeries).

I don't stick to use other than 0 for celleb_vtermno, so I'll
#define it to 0. That's the simplest way.

Best regards,
Kou Ishizaki