[PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

Roland Dreier rdreier at cisco.com
Fri Jan 12 06:56:18 EST 2007


 > >  	spin_lock_irqsave(&ehca_cq_idr_lock, flags);
 > >  	while (my_cq->nr_callbacks)
 > >  		yield();

 > Isn't that code outright buggy?  Calling into the scheduler with a
 > spinlock held and local interrupts disabled...

Yes, absolutely -- if nr_callbacks is ever nonzero then this will
obviously crash instantly.

 - R.



More information about the Linuxppc-dev mailing list