[PATCH 4/7] MPIC MSI allocator

Segher Boessenkool segher at kernel.crashing.org
Fri Jan 12 04:27:12 EST 2007


>>> +	/* Reserve source numbers we know are reserved in the HW */
>>> +	for (i = 0;   i < 8;   i++) __mpic_msi_reserve_hwirq(mpic, i);
>>> +	for (i = 42;  i < 46;  i++) __mpic_msi_reserve_hwirq(mpic, i);
>>> +	for (i = 100; i < 105; i++) __mpic_msi_reserve_hwirq(mpic, i);
>>
>> Coding style.  The ranges you reserve are a bit too wide,
>> but that is certainly safe.
>
> Can you clarify that comment a bit for me?    Why are they too wide, 
> and
> if they are too wide, how are they still safe?

A few vectors that can be used freely are marked as
not being so.  That is fine, there are plenty left.


Segher




More information about the Linuxppc-dev mailing list