[PATCH 4/7] MPIC MSI allocator
Segher Boessenkool
segher at kernel.crashing.org
Fri Jan 12 02:14:48 EST 2007
> + msi_debug("found U3, guessing msi allocator setup\n");
> +
> + /* Reserve source numbers we know are reserved in the HW */
> + for (i = 0; i < 8; i++) __mpic_msi_reserve_hwirq(mpic, i);
> + for (i = 42; i < 46; i++) __mpic_msi_reserve_hwirq(mpic, i);
> + for (i = 100; i < 105; i++) __mpic_msi_reserve_hwirq(mpic, i);
Coding style. The ranges you reserve are a bit too wide,
but that is certainly safe.
> +static int mpic_msi_reserve_u3_hwirqs(struct mpic *mpic) { return -1;
> }
Coding style.
Looks good to me otherwise.
Segher
More information about the Linuxppc-dev
mailing list