[PATCH] ppc: mpic of_node_get cleanup

Mariusz Kozlowski m.kozlowski at tuxland.pl
Tue Jan 2 22:52:47 EST 2007


Hello,

	No need for ?: because of_node_get() can handle NULL argument.

Signed-off-by: Mariusz Kozlowski <m.kozlowski at tuxland.pl>

 arch/powerpc/sysdev/mpic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -upr linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/mpic.c linux-2.6.20-rc2-mm1-b/arch/powerpc/sysdev/mpic.c
--- linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/mpic.c	2006-12-24 05:00:32.000000000 +0100
+++ linux-2.6.20-rc2-mm1-b/arch/powerpc/sysdev/mpic.c	2007-01-02 02:02:54.000000000 +0100
@@ -912,7 +912,7 @@ struct mpic * __init mpic_alloc(struct d
 	
 	memset(mpic, 0, sizeof(struct mpic));
 	mpic->name = name;
-	mpic->of_node = node ? of_node_get(node) : NULL;
+	mpic->of_node = of_node_get(node);
 
 	mpic->irqhost = irq_alloc_host(IRQ_HOST_MAP_LINEAR, 256,
 				       &mpic_host_ops,


-- 
Regards,

	Mariusz Kozlowski



More information about the Linuxppc-dev mailing list