[PATCH] ppc: vio of_node_put cleanup

Mariusz Kozlowski m.kozlowski at tuxland.pl
Tue Jan 2 22:38:36 EST 2007


Hello,

	This patch removes redundant argument check for of_node_put().

Signed-off-by: Mariusz Kozlowski <m.kozlowski at tuxland.pl>

 arch/powerpc/kernel/vio.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff -upr linux-2.6.20-rc2-mm1-a/arch/powerpc/kernel/vio.c linux-2.6.20-rc2-mm1-b/arch/powerpc/kernel/vio.c
--- linux-2.6.20-rc2-mm1-a/arch/powerpc/kernel/vio.c	2006-12-24 05:00:32.000000000 +0100
+++ linux-2.6.20-rc2-mm1-b/arch/powerpc/kernel/vio.c	2007-01-02 01:55:31.000000000 +0100
@@ -199,10 +199,8 @@ EXPORT_SYMBOL(vio_unregister_driver);
 /* vio_dev refcount hit 0 */
 static void __devinit vio_dev_release(struct device *dev)
 {
-	if (dev->archdata.of_node) {
-		/* XXX should free TCE table */
-		of_node_put(dev->archdata.of_node);
-	}
+	/* XXX should free TCE table */
+	of_node_put(dev->archdata.of_node);
 	kfree(to_vio_dev(dev));
 }
 


-- 
Regards,

	Mariusz Kozlowski



More information about the Linuxppc-dev mailing list