[PATCH 2/2] ehea: NAPI multi queue TX/RX path for SMP
Jan-Bernd Themann
ossthema at de.ibm.com
Wed Feb 28 20:23:16 EST 2007
Hi,
> >
> > +static inline int ehea_hash_skb(struct sk_buff *skb, int num_qps)
> > +{
> > + u32 tmp;
> > + if ((skb->nh.iph->protocol == IPPROTO_TCP)
> > + && skb->protocol == ETH_P_IP) {
>
> skb->protocol has network byte order. The ETH_P_IP test should also
> logically come before checking the IP protocol.
>
fixed.
> > + tmp = (skb->h.th->source + (skb->h.th->dest << 16)) % 31;
>
> Only locally generated packets have a valid h.th pointer.
>
good point. I'll fix that.
I'll send a new patch set later today
Thanks,
Jan-Bernd
More information about the Linuxppc-dev
mailing list