[RFC 2/7] Unite all PCI-e on 85xx and 86xx under one codebase

Zang Roy-r61911 tie-fei.zang at freescale.com
Tue Feb 27 02:52:04 EST 2007


 
> On Feb 26, 2007, at 12:41 AM, Zang Roy-r61911 wrote:
> 
> >
> >> On Feb 15, 2007, at 8:44 PM, Andy Fleming wrote:
> >>
> >>> Add 85xx PCI express memory map register.
> >>>
> >>> Signed-off-by: Roy Zang <tie-fei.zang at freescale.com>
> >>> Acked-by: Andy Fleming <afleming at freescale.com>
> >>> ---
> >>>  include/asm-ppc/immap_85xx.h |   75
> >> +++++++++++++++++++++++++++++++
> >>> +++++++++++
> >>>  1 files changed, 75 insertions(+), 0 deletions(-)
> >>
> >> Are the 86xx and 85xx structs the same?  If so, can we 
> pull them out 
> >> of immap_*.h into a sysdev/fsl_pcie.h
> >>
> >> (and lose the typedef while you're at it).
> > They have same structs. But I do not think it is proper to 
> move them 
> > into sysdev/fsl_pcie.h now. sysdev/fsl_pcie.c does not use  this 
> > header file.
> > plaforms/85xx/pci.c use it to set up memory map windows.
> > In fact, there is little difference between immap_85xx.h and 
> > immap_86xx.h.
> > After the migration from ppc to powerpc, we can unify them together.
> 
> Why wait, I don't believe we support pcie in arch/ppc for 
> anything fsl platform and the PCI support is different 
> between arch/powerpc and arch/ppc.
> 
Wait  to unify immap  together :-).
I agree to separate pcie struct for  arch/powerpc, then the code in
arch/powerpc will not depend header file include/asm-ppc.
I will provide patch to Andy and Jon tomorrow.
Roy



More information about the Linuxppc-dev mailing list