[dtc] Fix flat_dt_property structure

David Gibson david at gibson.dropbear.id.au
Mon Feb 26 11:02:24 EST 2007


The structure in flat_dt.h defining the layout of a proprety within
the flat device tree is incorrect.  It has the offset to the
property's name, then the length when in fact (according to
booting-without-of.txt and the output of dtc) then length should come
first, followed by the name offset.

In fact, this structure is never used so the mistake doesn't break
anything, but it should still be fixed to avoid misleading people.

Signed-off-by: David Gibson <david at gibson.dropbear.id.au>

Index: dtc/flat_dt.h
===================================================================
--- dtc.orig/flat_dt.h	2007-02-26 10:59:03.000000000 +1100
+++ dtc/flat_dt.h	2007-02-26 10:59:45.000000000 +1100
@@ -37,8 +37,8 @@ struct reserve_entry {
 };
 
 struct flat_dt_property {
-	uint32_t nameoff;
 	uint32_t len;
+	uint32_t nameoff;
 	char data[0];
 };
 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the Linuxppc-dev mailing list