[PATCH 1/4 (final?)] ps3fb: thread updates

[Geert Uytterhoeven]

On Wed, 21 Feb 2007, Andrew Morton wrote:
> On Tue, 20 Feb 2007 11:42:04 +0100 (CET)
> Geert Uytterhoeven <Geert.Uytterhoeven at sonycom.com> wrote:
> 
> > ps3fb: Replace the kernel_thread and the semaphore by a proper kthread, which is
> > simply woken up when the screen must be updated
> 
> <goes off and generates the incremental diff again so we can see what changed>

Sorry, I thought you were just going to replace the patch you already had in
your queue/heap/stack.

> @@ -808,16 +807,13 @@ static int ps3fb_ioctl(struct fb_info *i
>  
>  static int ps3fbd(void *arg)
>  {
> -	DEFINE_WAIT(wait);
> -	DECLARE_WAIT_QUEUE_HEAD(wq);
> -
>  	while (!kthread_should_stop()) {
> -		prepare_to_wait(&wq, &wait, TASK_INTERRUPTIBLE);
> -		if (!ps3fb.is_kicked)
> -			schedule();
> -		finish_wait(&wq, &wait);
> -		ps3fb.is_kicked = 0;
> -		ps3fb_sync(0);	/* single buffer */
> +		set_current_state(TASK_INTERRUPTIBLE);
> +		if (ps3fb.is_kicked) {
> +			ps3fb.is_kicked = 0;
> +			ps3fb_sync(0);	/* single buffer */
> +		}
> +		schedule();
>  	}
>  	return 0;
>  }
> _
> 
> There's still no try_to_freeze() in there.  Shouldn't we have one?

Thanks, I'll add it.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven at sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium