[PATCH 12/14] Add device tree for Ebony

Yoder Stuart-B08248 stuart.yoder at freescale.com
Wed Feb 21 06:22:07 EST 2007


A couple of minor nits...

> +	UIC0: interrupt-controller { /* UIC0 */
> +		device_type = "interrupt-controller";
> +		compatible = "ibm,uic440gp", "ibm,uic";
> +		interrupt-controller;
> +		cell-index = <0>;
> +		dcr-reg = <0c0 009>;
> +		#address-cells = <0>;
> +		#size-cells = <0>;
> +		#interrupt-cells = <2>;
> +
> +		UIC1: interrupt-controller at 1 { /* UIC1 */
> +			device_type = "interrupt-controller";
> +			compatible = "ibm,uic440gp", "ibm,uic";
> +			interrupt-controller;
> +			cell-index = <1>;
> +			dcr-reg = <0d0 009>;
> +			#address-cells = <0>;
> +			#size-cells = <0>;
> +			#interrupt-cells = <2>;
> +			interrupts = <1e 4 1f 4>; /* cascade */
> +		};
> +	};

Since UIC1 is cascaded off UIC0 in the interrupt tree,
UIC1 should have an interrupt-parent pointing to UIC0
so the interrupt tree can be traversed to the root.

I know this was beaten to death last week, but I would
still argue that in the device tree UIC0 and UIC1 should
be siblings.  (In the interrupt tree the cascade relationship
is described through interrupt-parent).

> +	chosen {
> +		linux,stdout-path = "/plb/opb at 0/serial at 140000200";
> +		linux,initrd-start = <0>; /* FIXME */
> +		linux,initrd-end = <0>;
> +		interrupt-controller = <&UIC0>;
> +	};
> +};

I thought there was agreement (last week) that interrupt-controller
would no longer be under /chosen.  I submitted a patch to
booting-without-of.txt to make this obsolete.   The kernel
does not use the property, and we can find a different place for
it in the future if we need it.

Stuart



More information about the Linuxppc-dev mailing list