macros and dtc

Yoder Stuart-B08248 stuart.yoder at freescale.com
Tue Feb 20 08:06:34 EST 2007


 

> -----Original Message-----
> From: Dan Malek [mailto:dan at embeddedalley.com] 
> Sent: Monday, February 19, 2007 2:17 PM
> To: Yoder Stuart-B08248
> Cc: Kumar Gala; Linux PPC Dev ML; Jon Loeliger; David Gibson
> Subject: Re: macros and dtc
> 
> 
> On Feb 19, 2007, at 1:57 PM, Yoder Stuart-B08248 wrote:
> 
> > bus-frequency = <33MHZ> is much better than
> > bus-frequency = <13ab6680>
> 
> Except, 33MHZ isn't a valid macro name, and if
> these constants would have been _decimal_
> in the first place, 33000000, or 33333333 would
> be understandable :-)  I've screwed up by thinking
> (or not, I guess) these are decimal numbers.....
> I agree with you, though.  Of course, these values
> should be zero in the dts and filled in by
> the boot loader/wrapper.

Ok. (guess I picked a bad example:)  The main point,
though, is that symbolic names are generally more
helpful and clear than bare constants.  

Stuart



More information about the Linuxppc-dev mailing list