[RFC 2/3] zImage: SMP hold

Paul Mackerras paulus at samba.org
Mon Feb 19 11:32:59 EST 2007


Geoff Levand writes:

> +void smp_secondary_hold(unsigned int cpu_id)
> +{
> +	while(!smp_secondary_entry)
> +		(void)0;

Using a barrier() here rather than making smp_secondary_entry volatile
would be better, I think.

Also, what's the lifetime of this code after smp_secondary_entry is
set, i.e. how do we know the kernel running on the primary cpu will
wait for the secondary cpus to have got through this code into the
kernel before it reuses this memory for something else?

Paul.



More information about the Linuxppc-dev mailing list