[PATCH] (pata-2.6 fix queue) sl82c105: DMA support code cleanup

Bartlomiej Zolnierkiewicz bzolnier at gmail.com
Thu Feb 15 06:48:32 EST 2007


On Tuesday 13 February 2007 22:43, Sergei Shtylyov wrote:
> Fold the now equivalent code in the ide_dma_check() method into a mere call to
> ide_use_dma().  Make config_for_dma() return non-zero if DMA mode has been set
> and call it from the ide_dma_check() method instead of ide_dma_on().
> Also, defer writing the DMA timings to the chip registers until DMA is actually
> turned on (and do not enable IORDY for DMA).  Remove unnecessary code from the
> init_hwif() method, improve its looks overall, and also rename the driver's
> ide_dma_check() and dma_start() methods.
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov at ru.mvista.com>
> 
> ---
> The patch has been actually tested at last. :-)
> Note that now this driver can be joined to the ide-use-fast-pio patch.

applied



More information about the Linuxppc-dev mailing list