[PATCH 1/3] PS3: Vuart cleanups

Paul Mackerras paulus at samba.org
Wed Feb 14 11:26:50 EST 2007


Geoff Levand writes:

> Cleanups for the PS3 vuart driver.

You seem to have the whole patch + description in there twice...

> -int __init ps3_vuart_init(void)
> +int __init ps3_vuart_bus_init(void)
>  {
>  	int result;
>  
>  	pr_debug("%s:%d:\n", __func__, __LINE__);
> -	result = bus_register(&ps3_vuart);
> +	init_MUTEX(&vuart_bus_priv.probe_mutex);
> +	result = bus_register(&ps3_vuart_bus);
>  	BUG_ON(result);
>  	return result;
>  }

[snip]

> +core_initcall(ps3_vuart_bus_init);

Might be nice to check that you're actually on a PS3 before
registering the bus perhaps?

Paul.



More information about the Linuxppc-dev mailing list