[PATCH] powerpc: add of_get_mac_address() and update fsl_soc.c to use it

Olof Johansson olof at lixom.net
Wed Feb 14 11:21:33 EST 2007

On Wed, Feb 14, 2007 at 11:00:19AM +1100, Benjamin Herrenschmidt wrote:
> > +	return get_property(np, "address", NULL);
> Since there is so much room for confusion with "address", please at
> least do some basic sanity checking, like check that it's size is 6
> bytes and maybe that the multicast bit isn't set.

No need to reinvent the wheel, is_valid_ether_addr() is easy to use.

Might still want to check the property length though.


More information about the Linuxppc-dev mailing list