[PATCH 05/12] power management: no valid states w/o pm_ops + docs

Johannes Berg johannes at sipsolutions.net
Wed Feb 14 03:08:40 EST 2007


On Tue, 2007-02-13 at 13:12 +0100, Pavel Machek wrote:
> Hi!
> 
> > This patch changes /sys/power/state to not advertise any valid states
> > (except for disk if SOFTWARE_SUSPEND is enabled) when no pm_ops have been
> > set so userspace can easily discover what states should be available.
> > 
> > Also, because the pm ops in powermac are obviously not using them as
> > intended, I added documentation for it in kernel-doc format.
> > 
> > Reordering the fields in struct pm_ops not only makes the output of
> > kernel-doc make more sense but also removes a hole from the structure on
> > 64-bit platforms.
> > 
> > Signed-off-by: Johannes Berg <johannes at sipsolutions.net>
> > Cc: linux-pm at lists.osdl.org
> > Cc: Rafael J. Wysocki <rjw at sisk.pl>
> > Cc: Pavel Macheck <pavel at ucw.cz>
> 
> Looks okay to me.

Are you going to pick it up or should I send it to someone else?

johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20070213/855488cc/attachment.pgp>


More information about the Linuxppc-dev mailing list