[RFC] mpc5200 device tree bindings refinement

Grant Likely grant.likely at secretlab.ca
Wed Feb 14 02:37:18 EST 2007


On 2/12/07, Mark A. Greer <mgreer at mvista.com> wrote:
> On Mon, Feb 12, 2007 at 01:48:07PM -0700, Yoder Stuart-B08248 wrote:
> >
> > If the property is to distinguish between multiple
> > devices of the same type how about using
> > 'device-index' or 'device-idx' as a property name.
>
> 2) I (we?) really don't need to know a device index, per se.  What I
> need to know is what set of regs within a block of regs or bits with a
> single register are associated with a device.  Whether its device 0
> or 1 or... doesn't really matter.  That's why I'm partial to
> 'register-set' but I'm always open.

I am concerned that this ends up been premature optimization (of the
device tree).  Hardware designers are fickle people and like to change
shared registers between different chips.  I do agree that logically
the device is attached to a block of registers that can be described
in a separate node (child of the soc node).  But since we have no idea
if it's going to change in the next chip, it's probably better just to
describe it as the block-index on the soc.

Of course, I this begs the argument: "why do we describe anything
about an soc at all; why not just specify the SoC name/revision and be
done with it?"  I don't like that direction myself, but I do find it
non-trivial to find the sweet spot between minimal and "fully-loaded"
device trees.  That just highlights to me that this is just as much of
an art as it is science.  :)

On 2/12/07, Yoder Stuart-B08248 <stuart.yoder at freescale.com> wrote:
> > > Maybe ip-block-index ? :-) The word "cell" can be confusing... or just
> > > "block-index" ?
> >
> > I'm happy with 'block-index'
> >
> If it could be changed I like block-index better.
>
BTW, I'm cool with block-index or ip-block-index too.

Cheers,
g.
-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195



More information about the Linuxppc-dev mailing list