[RFC] mpc5200 device tree bindings refinement

Yoder Stuart-B08248 stuart.yoder at freescale.com
Tue Feb 13 07:34:04 EST 2007


 

> -----Original Message-----
> From: linuxppc-dev-bounces+b08248=freescale.com at ozlabs.org 
> [mailto:linuxppc-dev-bounces+b08248=freescale.com at ozlabs.org] 
> On Behalf Of Grant Likely
> Sent: Friday, February 09, 2007 1:30 AM

[snip]

>  3) The soc5200 node
>  -------------------
> -This node describes the on chip SOC peripherals.  Every mpc52xx based
> +This node describes the on chip SOC peripherals.  Every mpc5200 based
>  board will have this node, and as such there is a common naming
>  convention for SOC devices.
>  
> @@ -125,71 +144,107 @@ name			type		
> description
>  device_type		string		must be "soc"
>  ranges			int		should be <0 
> baseaddr baseaddr+10000>
>  reg			int		must be <baseaddr 10000>
> +compatible		string		mpc5200: "mpc5200-soc"
> +					mpc5200b: 
> "mpc5200b-soc\0mpc5200-soc"
> +system-frequency	int		Fsystem frequency; source of all
> +					other clocks.
> +bus-frequency		int		IPB bus 
> frequency in HZ.  Clock rate

My suggestion would be to _not_ create a brand new property
called system-frequency.  Could we not use the existing
clock-frequency property instead (defined to mean the
Fsystem frequency)?

Currently across many device types (e.g. PCI, serial) the
clock-frequency property is used to describe the clock
frequency in a way specific to that device.  Could that work
here?

If you did need to create a new property unique to this
particular device it should have the vendor name preprended
to the property (e.g. linux,phandle).

If this property is generally across all soc device types
the "soc" section in booting_without_of.txt should
be updated with a clear definition of what the property
means.

Stuart Yoder



More information about the Linuxppc-dev mailing list