[PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

Timur Tabi timur at freescale.com
Fri Feb 9 00:27:43 EST 2007


Li Yang-r58472 wrote:

> No, we don't know if the BD ring is in MURAM or main memory as it is
> configurable.  iopa() is best choice to handle both case, IMHO.

The above code would only be used if the BD is in MURAM.  The "if 
bd_mem_part == MEM_PART_MURAM" would stay.

If the BD ring can be in main memory, then I don't think we should be 
using a function called "iopa" to get its physical address.  It's 
conceivable that one day, iopa() will only work on memory that's been 
ioremap'ed.




More information about the Linuxppc-dev mailing list