[PATCH 1/3] add USB setup code for 8349emds PB

[Li Yang-r58472]

> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd at arndb.de]
> Sent: Wednesday, February 07, 2007 4:47 PM
> To: Li Yang-r58472
> Cc: linuxppc-dev at ozlabs.org; Paul
> Subject: Re: [PATCH 1/3] add USB setup code for 8349emds PB
> 
> On Wednesday 07 February 2007 03:22, Li Yang-r58472 wrote:
> >
> > > I'm not sure if scanning through the device tree to find mmio
> > > addresses is still considered valid style. I would instead prefer
> > > you to provide a of_platform_driver that attaches to the
> > > respective 'compatible' property and does the register access
> > > in its probe() function in order to not conflict with other
drivers.
> >
> > The driver will not use of_platform_driver for it to be used through
> > multiple architectures.
> 
> Huh? I don't understand. You currently use of_find_compatible_node(),
> which is also platform-specific.

Do you mean to create an of_plarform_driver here just to do the platform
initialization?  The true USB driver can only takes platform_device as
it is used by multiple architectures.
btw: We don't access the mmio address of the device here.  We just need
to read some property from the device tree.

- Leo