[PATCH 1/3] add USB setup code for 8349emds PB

Li Yang-r58472 LeoLi at freescale.com
Wed Feb 7 13:27:20 EST 2007


> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org]
> Sent: Wednesday, February 07, 2007 12:31 AM
> To: Kumar Gala
> Cc: Li Yang-r58472; linuxppc-dev at ozlabs.org; Paul
> Subject: Re: [PATCH 1/3] add USB setup code for 8349emds PB
> 
> 
> On Feb 6, 2007, at 8:37 AM, Kumar Gala wrote:
> 
> >
> > On Feb 6, 2007, at 3:05 AM, Li Yang wrote:
> >
> >> Add board specific initialization code for USB
> >> to work in both MPH and DR mode for MPC8349EMDS
> >> PB board.
> >>
> >> Signed-off-by: Li Yang <leoli at freescale.com>
> >> ---
> >>
> >> arch/powerpc/platforms/83xx/Kconfig       |    4 ++
> >> arch/powerpc/platforms/83xx/mpc834x_sys.c |   79
+++++++++++++++++++
> >> ++++++++++
> >> arch/powerpc/platforms/83xx/mpc834x_sys.h |    2 +
> >> arch/powerpc/platforms/83xx/mpc83xx.h     |   18 +++++++
> >> 4 files changed, 103 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/powerpc/platforms/83xx/Kconfig b/arch/powerpc/
> >> platforms/83xx/Kconfig
> >> index edcd5b8..5371645 100644
> >> --- a/arch/powerpc/platforms/83xx/Kconfig
> >> +++ b/arch/powerpc/platforms/83xx/Kconfig
> >> @@ -59,4 +59,8 @@ config PPC_MPC836x
> >> 	select PPC_INDIRECT_PCI
> >> 	default y if MPC8360E_PB
> >> +config 834x_USB_SUPPORT
> >> +	bool
> >> +	default y if MPC834x_SYS && (USB || USB_GADGET)
> >> +
> >
> > I'm still not convinced we need a new config option for this.
> 
> Ok, I see what this now accomplishes, but why don't we just build the
> support in always, lets just remove the config option altogether?

To save some space and time for embedded product which doesn't really
need usb?

- Leo



More information about the Linuxppc-dev mailing list