[PATCH] Missing ifndef __ASSEMBLY__ in include/asm-powerpc/dcr.h

David Gibson david at gibson.dropbear.id.au
Tue Feb 6 10:56:39 EST 2007


On Mon, Feb 05, 2007 at 02:33:10PM -0500, Mathieu Desnoyers wrote:
> Missing ifndef __ASSEMBLY__ in include/asm-powerpc/dcr.h
> 
> A missing structure forward declaration causes a lot of warnings when
> compiling for a powerpc 405. Because this header is used for assembly
> too, the declaration must be put within #ifndef __ASSEMBLY__, as should
> be the function prototypes.
> 
> This patch applies on 2.6.20.

This is the wrong fix.  The arch/powerpc version of dcr.h, unlike the
arch/ppc version, should never be included in assembler.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the Linuxppc-dev mailing list