[PATCH 8/9] mpc82xx: Update mpc8272ads, and factor out PCI and reset.
Scott Wood
scottwood at freescale.com
Fri Aug 31 01:17:14 EST 2007
On Thu, Aug 30, 2007 at 09:56:16AM -0500, Kumar Gala wrote:
> It don't feel its a mishmash of crap its just how things are
> defined. Maybe the SOC node was a mistake, but I think we are past
> the point of return on that.
The node itself wasn't a mistake -- the IMMR is relocatable, so it should
be under a bus node. The mistake was assuming the PCI ranges went
straight to the CPU space, rather than getting translated through the
parent bus's ranges. We got away with that mistake because of a similar
bug in the 32-bit PCI code.
In the past few months, this issue began to be addressed in a handful of
device trees. In the device trees I prepared, I used separate bus and
control nodes. In the 8544, 8548, and 8641 device trees, extra ranges
were hacked into the soc node. All other PCI-bearing Freescale device
tree files are still broken.
I don't think a few months is an unrecoverable legacy.
> Having one platform's device tree be different just creates confusion
> to our customers.
The intent isn't for 82xx to be different from everything else -- it's
simply the first one to get fixed in this way. Incremental changes, and
what not.
Note that it would be quite easy to make the code accept either type of
device tree.
> While there isn't anything technically wrong with what your proposing
> it will cause support issues down the line which I want to avoid.
Such as?
-Scott
More information about the Linuxppc-dev
mailing list