[PATCH 3/3] [POWERPC] Add PCI support for AMCC 440EPx (sequoia)

Josh Boyer jwboyer at linux.vnet.ibm.com
Tue Aug 28 03:22:45 EST 2007


On Mon, 27 Aug 2007 08:21:35 +0200
Stefan Roese <sr at denx.de> wrote:

> > > +++ b/arch/powerpc/platforms/44x/ppc440epx-pci.c
> > > @@ -0,0 +1,192 @@
> > > +/*
> > > + * PPC44x PCI host support
> > > + *
> > > + * Vitaly Bordug <vitb at kernel.crashing.org>
> > > + * Stefan Roese <sr at denx.de>
> > > + *
> > > + * Based on arch/ppc sequoia pci bits, that are
> > > + * Copyright 2006-2007 DENX Software Engineering, Stefan Roese
> > > <sr at denx.de> + *
> > > + * Based on bamboo.c from Wade Farnsworth <wfarnsworth at mvista.com>
> > > + *      Copyright 2004 MontaVista Software Inc.
> > > + *      Copyright 2006 AMCC
> > > + * This program is free software; you can redistribute  it and/or modify
> > > it + * under  the terms of  the GNU General  Public License as published
> > > by the + * Free Software Foundation;  either version 2 of the  License,
> > > or (at your + * option) any later version.
> > > + */
> >
> > Unless there really is something peculiar about the EPx bridge
> > compared to say the GP, EP and other 4xx bridges, this should have a
> > more general name.
> 
> We originally started naming this file sequoia-pci.c and changed it to be 
> 440EPx specific (just by renaming). But you are right of course. We should 
> make it even more generic for 4xx PCI support. Perhaps we will overlook some 
> problems with other 4xx platforms, but those should be solved when other 
> platforms (Josh: 440ep and 405gp? ;)) will be added.
> 
> So what should it be called? arch/powerpc/syslib/ppc4xx_pci.c ?

That would work, yes.  I'd be happy to test out 440ep, 440gp, and 405gp
once the patches are reworked a bit per David and Segher's comments.

josh



More information about the Linuxppc-dev mailing list