asm-ppc header issues when building ARCH=powerpc

Kumar Gala galak at kernel.crashing.org
Fri Aug 24 04:00:24 EST 2007


On Aug 23, 2007, at 12:33 PM, Scott Wood wrote:

> On Thu, Aug 23, 2007 at 12:47:57PM +1000, David Gibson wrote:
>>> ./drivers/mtd/maps/tqm834x.c:#include <asm/ppcboot.h>
>>> ./drivers/mtd/maps/pq2fads.c:#include <asm/ppcboot.h>
>>
>> Although these both have an extern of type bd_t (defined in
>> ppcboot.h), afaict they don't actually use it, so these should be
>> removable.
>
> They look like they're using it to me...  See the bd->bi_flashstart  
> and
> bd->bi_flashsize references in init_pq2fads_mtd.

Both of these are dead in one way or another.  pq2fads.c isn't in the  
makefile and you can't Kconfig tqm834x.c into existence.  Thus my  
patch to remove them.

- k



More information about the Linuxppc-dev mailing list