[PATCH v6 1/2] [POWERPC] fsl_soc: add support for fsl_spi

Stephen Rothwell sfr at canb.auug.org.au
Thu Aug 23 13:24:21 EST 2007


Hi Anton,

On Wed, 22 Aug 2007 18:57:32 +0400 Anton Vorontsov <avorontsov at ru.mvista.com> wrote:
>
> +	sysclk = *(u32 *)of_get_property(np, "bus-frequency", NULL);

I just cringe everytime I see someone dereference a pointer they got from
somewhere (effectively) external without checking for NULL.  I realise
that sometimes "that can't happen" ...

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20070823/af2b6df5/attachment.pgp>


More information about the Linuxppc-dev mailing list