[PATCH] fix compile warning in arch/powerpc/kernel/sysfs.c

Michael Neuling mikey at neuling.org
Fri Aug 17 13:40:13 EST 2007


This fixes the following warning:
arch/powerpc/kernel/sysfs.c:388: warning: ignoring return value of
'sysfs_create_group', declared with attribute warn_unused_result

Signed-off-by: Michael Neuling <mikey at neuling.org>
---
 arch/powerpc/kernel/sysfs.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Index: linux-2.6-ozlabs/arch/powerpc/kernel/sysfs.c
===================================================================
--- linux-2.6-ozlabs.orig/arch/powerpc/kernel/sysfs.c
+++ linux-2.6-ozlabs/arch/powerpc/kernel/sysfs.c
@@ -378,14 +378,18 @@ EXPORT_SYMBOL_GPL(cpu_add_sysdev_attr);
 
 int cpu_add_sysdev_attr_group(struct attribute_group *attrs)
 {
-	int cpu;
+	int cpu, err;
 	struct sys_device *sysdev;
 
 	mutex_lock(&cpu_mutex);
 
 	for_each_possible_cpu(cpu) {
 		sysdev = get_cpu_sysdev(cpu);
-		sysfs_create_group(&sysdev->kobj, attrs);
+		err = sysfs_create_group(&sysdev->kobj, attrs);
+		if (err) {
+			mutex_unlock(&cpu_mutex);
+			return err;
+		}
 	}
 
 	mutex_unlock(&cpu_mutex);





More information about the Linuxppc-dev mailing list