[PATCH] powerpc: fix i2c device string format

Guennadi Liakhovetski g.liakhovetski at gmx.de
Thu Aug 16 08:23:37 EST 2007


On Wed, 15 Aug 2007, Scott Wood wrote:

> BTW, is there any reason this stuff is fsl_soc specific?  I'd think
> prom_parse.c (or better yet, drivers/of/ or drivers/i2c/, now that some OF
> calls have been factored out) would be a better place.

Minimal intrusion:-) Initially in your patch you added the 
of_register_i2c_devices() function to prom_parse.c, of_find_i2c_driver() 
is just an abstracted out search function, that is practically inlined in 
the former one. I moved of_register_i2c_devices() into fsl_soc.c because 
that's where its only (ATM) caller fsl_i2c_of_init() is. So, this way it's 
all nicely inlined by the compiler, and we don't need any external 
functions... If we get another user of this function, sure, we can move it 
out. So far no other i2c bus driver is trying to parse OF i2c tree.

Thanks
Guennadi
---
Guennadi Liakhovetski



More information about the Linuxppc-dev mailing list