[PATCH] remove gratuitous reads from pasemi pci config space methods

Olof Johansson olof at lixom.net
Sun Aug 12 09:57:41 EST 2007


On Thu, Aug 09, 2007 at 04:37:27PM -0500, Nathan Lynch wrote:
> The pasemi pci configuration space write method reads the written
> location immediately after the write is performed, presumably in order
> to flush the write.  However, configuration space writes are not
> allowed to be posted, making these reads gratuitous.  Furthermore,
> this behavior potentially causes us to violate the PCI PM spec when
> changing between e.g. D0 and D3 states, because a delay of up to 10ms
> may be required before the OS accesses configuration space after the
> write which initiates the transition.
> 
> Remove the unnecessary reads from pa_pxp_write_config.

Thanks!

> Signed-off-by: Nathan Lynch <ntl at pobox.com>

Acked-by: Olof Johansson <olof at lixom.net>


-Olof



More information about the Linuxppc-dev mailing list