[U-Boot-Users] MPC83xx - previous patch to set MBAR

[Alfred Manheim]

This was to the wrong group.

Thanks for the responses and the clarification. The "needed for CodeWarrior
only" part is what I suspected.

Keith Mund

-----Original Message-----
From: linuxppc-dev-bounces+alfman=austin.rr.com at ozlabs.org
[mailto:linuxppc-dev-bounces+alfman=austin.rr.com at ozlabs.org] On Behalf Of
Liu Dave-r63238
Sent: Wednesday, August 01, 2007 9:15 PM
To: Phillips Kim-R1AAHA; Keith Mund
Cc: linuxppc-dev at ozlabs.org; u-boot-users at lists.sourceforge.net
Subject: RE: [U-Boot-Users] MPC83xx - previous patch to set MBAR

> > The end result simply adds a line to set MBAR to match IMMRBAR.
> > 
> >         lis     r3, CFG_IMMRBAR at h
> >         ori     r3, r3, CFG_IMMRBAR at l
> >         stw     r3, IMMRBAR(r4)
> > +       mtspr   MBAR, r3
> > 
> > Are these patches routinely added to the mainstream u-boot code? 
> > 
> > Is there any reason why this fix is not a good idea?
> > 
> does setting MBAR really fix anything?
> 
> MBAR doesn't live up to its name.  It's a general-purpose scratch 
> register - the hardware doesn't do anything with it.  So, wrt

Kim is right.

MBAR setting is added by two years ago, it is not really fix anything.

I set the MBAR to be easier to use the CodeWarriror. The CodeWarrior must
set the MBAR first, then it will be able to access the IMMR.

Dave
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev at ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev