[PATCH 5/6] PowerPC 440EPx: Sequoia board support

Segher Boessenkool segher at kernel.crashing.org
Wed Aug 1 15:01:17 EST 2007


>> +	{ /* 440EPX  - without Security/Kasumi  */
>> +		.pvr_mask		= 0xf0000fff,
>> +		.pvr_value		= 0x200008D4,
>> +		.cpu_name		= "440EPX - no Security/Kasumi",
>> +		.cpu_features		= CPU_FTRS_44X,
>> +		.cpu_user_features	= COMMON_USER_BOOKE | PPC_FEATURE_HAS_FPU, /* 
>> 440EPX has an FPU */
>> +		.icache_bsize		= 32,
>> +		.dcache_bsize		= 32,
>> +	},
>
> Since the with/without Security/Kasumi versions have no differences in
> their cputable entry other than the PVR, couldn't you just remove the
> relevant PVR bit from the mask and use a single entry?

And get rid of the stupid "has an FPU" comment at the same time
please :-)


Segher




More information about the Linuxppc-dev mailing list