[PATCH v3] [2.6.22] pasemi: cpufreq driver
linux at dominikbrodowski.net
Sun Apr 29 12:50:21 EST 2007
On Fri, Apr 27, 2007 at 12:46:01AM -0500, Olof Johansson wrote:
> + max_freq = (u32*) get_property(cpu, "clock-frequency", NULL);
(u32) or (32*) ?
> + cur_astate = get_cur_astate(policy->cpu);
May the different cores have different settings at initalization? e.g.
core 0: freq A
core 1: freq B
with (freq B > freq A)? If so, cur_astate is set wrongly, as the _effective_
frequency would be freq B, right?
> +#ifndef CONFIG_PPC_PASEMI_CPUFREQ
> + printk(KERN_WARNING "No cpufreq driver, powersavings modes disabled\n");
> + current_mode = 0;
This confuses me a bit -- does something else than cpufreq not work if
cpufreq is disabled?
Overall, the patch looks good to me.
More information about the Linuxppc-dev