[PATCH 3/13] powerpc: Add bootwrapper support for Marvell/mv64x60 hostbridge
Mark A. Greer
mgreer at mvista.com
Sat Apr 28 08:02:45 EST 2007
On Fri, Apr 27, 2007 at 04:01:55PM +1000, Paul Mackerras wrote:
> Mark A. Greer writes:
>
> > Makefile | 2
> > mv64x60.c | 581 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > mv64x60.h | 70 +++++++
> > 3 files changed, 652 insertions(+), 1 deletion(-)
>
> 650 lines just to set up a hostbridge - that seems like rather a lot.
Yes, it is. This probably won't make you feel any better but most of
the lines are #define's or table init lines. There's only a couple
hundred or so that are actual code.
> Why do we have to do this here? Isn't there some firmware that should
> do this for us?
Well, the firmware just doesn't do all the init that's required. And,
some of the init that it does do is wrong. For example, the window for
the MPSC (serial ctlr) to access main memory isn't set up so the kernel
mpsc driver can't dma. There are several other examles.
All of this init should be in the firmware but its Motorola/ECC's
firmware and I/we have no control over it. Given that, I/we have to do
the init somewhere. Either in the kernel or the bootwrapper.
I vote for the bootwrapper but then your vote is the only one that actually
counts. :)
Mark
More information about the Linuxppc-dev
mailing list